Решение на Четвърта задача - Unit тестване от Лазар Дилов

Обратно към всички решения

Към профила на Лазар Дилов

Код

Лог от изпълнението

F

Failures:

  1) spec passes for the correct solution
     Failure/Error: expect(SOLUTION).to pass_tests
       expected this solution to pass the tests:
       
         class Version
           VALID_VERSION_REGEXP = /\A\z|\A[0-9]+(\.[0-9]+)*\z/
         
           include Comparable
         
           def initialize(version = '')
             unless VALID_VERSION_REGEXP.match(version.to_s)
               raise ArgumentError, "Invalid version string '#{version}'"
             end
         
             @components = version.to_s
               .split('.')
               .map(&:to_i)
               .reverse
               .drop_while(&:zero?)
               .reverse
           end
         
           def <=>(other)
             @components <=> Version.new(other).internal_components
           end
         
           def internal_components(positions = 0)
             padding_size = positions - @components.size
         
             if padding_size > 0
               @components + [0] * padding_size
             elsif positions != 0
               @components.take(positions)
             else
               @components.dup
             end
           end
         
           def components(positions = 0)
             padding_size = positions - @components.size
         
             if padding_size > 0
               @components + [0] * padding_size
             elsif positions != 0
               @components.take(positions)
             else
               @components.dup
             end
           end
         
           def to_s
             @components.join('.')
           end
         
           class Range
             include Enumerable
         
             def initialize(start_version, end_version)
               @start_version = Version.new(start_version)
               @end_version   = Version.new(end_version)
             end
         
             def include?(version)
               (@start_version <=> version) < 1 && (@end_version <=> version) == 1
             end
         
             def each
               current_version = @start_version
         
               while (current_version <=> @end_version) == -1
                 yield current_version
         
                 current_version = increment_version(current_version)
               end
             end
         
             private
         
             def increment_version(version)
               components = version.internal_components(3)
         
               components[2] += 1
         
               components.to_enum.with_index.reverse_each do |_, index|
                 component = components[index]
         
                 if component >= 10 && components[index - 1]
                   components[index]      = 0
                   components[index - 1] += 1
                 end
               end
         
               Version.new(components.join('.'))
             end
           end
         end
       
       
       RSpec log:
       
         .............F..F....F...F
         
         Failures:
         
           1) Version#components when padding < 0 checks with argument < 0
              Failure/Error: expect(version.components(-2)).to match_array
              ArgumentError:
                attempt to take negative size
              # ./solution.rb:41:in `take'
              # ./solution.rb:41:in `components'
              # ./solution_spec.rb:77:in `block (4 levels) in <top (required)>'
         
           2) Version#components when version contains zero checks with zeros in the beginning
              Failure/Error: expect(version.components).to match_array [1, 2]
                expected collection contained:  [1, 2]
                actual collection contained:    [0, 0, 1, 2]
                the extra elements were:        [0, 0]
              # ./solution_spec.rb:93:in `block (4 levels) in <top (required)>'
         
           3) Version#== checks if version1 == version2
              Failure/Error: expect(Version.new("1.0.0") == Version.new("1")).to be false
                
                expected #<FalseClass:0> => false
                     got #<TrueClass:20> => true
                
                Compared using equal?, which compares object identity,
                but expected and actual are not the same object. Use
                `expect(actual).to eq(expected)` if you don't care about
                object identity in this example.
              # ./solution_spec.rb:122:in `block (3 levels) in <top (required)>'
         
           4) Version Range #to_a cheks with simple versions
              Failure/Error: expect(range.to_a).to match_array [
                expected collection contained:  ["0.1", "0.1.1", "0.1.2", "0.1.3", "0.1.4", "0.1.5", "0.1.6", "0.1.7", "0.1.8", "0.1.9"]
                actual collection contained:    [#<Version:0x007fae59e15438 @components=[0, 1]>, #<Version:0x007fae59e12238 @components=[0, 1, 1]>, #<Version:0x007fae59e11310 @components=[0, 1, 2]>, #<Version:0x007fae59e10528 @components=[0, 1, 3]>, #<Version:0x007fae59e0b5a0 @components=[0, 1, 4]>, #<Version:0x007fae59e0a4c0 @components=[0, 1, 5]>, #<Version:0x007fae59e075b8 @components=[0, 1, 6]>, #<Version:0x007fae59e06ac8 @components=[0, 1, 7]>, #<Version:0x007fae59e04f98 @components=[0, 1, 8]>, #<Version:0x007fae59dfff70 @components=[0, 1, 9]>]
                the missing elements were:      ["0.1", "0.1.1", "0.1.2", "0.1.3", "0.1.4", "0.1.5", "0.1.6", "0.1.7", "0.1.8", "0.1.9"]
              # ./solution_spec.rb:155:in `block (4 levels) in <top (required)>'
         
         Finished in 0.01222 seconds
         26 examples, 4 failures
         
         Failed examples:
         
         rspec ./solution_spec.rb:76 # Version#components when padding < 0 checks with argument < 0
         rspec ./solution_spec.rb:91 # Version#components when version contains zero checks with zeros in the beginning
         rspec ./solution_spec.rb:121 # Version#== checks if version1 == version2
         rspec ./solution_spec.rb:153 # Version Range #to_a cheks with simple versions
     # /tmp/d20161119-19072-8oeoz6/spec.rb:180:in `block (2 levels) in <top (required)>'
     # ./lib/language/ruby/run_with_timeout.rb:7:in `block (3 levels) in <top (required)>'
     # ./lib/language/ruby/run_with_timeout.rb:7:in `block (2 levels) in <top (required)>'

Finished in 0.74656 seconds
1 example, 1 failure

Failed examples:

rspec /tmp/d20161119-19072-8oeoz6/spec.rb:179 # spec passes for the correct solution

История (6 версии и 4 коментара)