Решение на Седма задача - ретроспекция от Делян Лафчиев

Обратно към всички решения

Към профила на Делян Лафчиев

Код

Лог от изпълнението

From https://github.com/fmi/ruby-retrospective-2016
 * branch            master     -> FETCH_HEAD
HEAD is now at a22cf37 Set rubocop version to 0.46.0 to fix obsolete cop errors
Cloning into 'submission'...
HEAD is now at 518032f Fix typos in using the identifier of class Version
From /tmp/ruby-retrospective-2016/checker
 * branch            master     -> FETCH_HEAD
 * [new branch]      master     -> upstream/master

Changes URL:
https://github.com/lovechief/ruby-retrospective-2016/compare/a22cf37e1e0...518032f4b80

'tasks/1/solution.rb' -> '/tmp/ruby-retrospective-2016/checker/tasks/1/solution.rb'
'tasks/2/solution.rb' -> '/tmp/ruby-retrospective-2016/checker/tasks/2/solution.rb'
'tasks/3/solution.rb' -> '/tmp/ruby-retrospective-2016/checker/tasks/3/solution.rb'
'tasks/4/solution.rb' -> '/tmp/ruby-retrospective-2016/checker/tasks/4/solution.rb'
'tasks/5/solution.rb' -> '/tmp/ruby-retrospective-2016/checker/tasks/5/solution.rb'
Inspecting 1 file
C

Offenses:

solution.rb:2:1: C: Use 2 (not 4) spaces for indentation.
    coefficient = { 'C' => 1.8, 'F' => 1, 'K' => 1.8 }
^^^^
solution.rb:3:28: C: Unnecessary spacing detected.
    constant = { 'C' => 32,  'F' => 0, 'K' => -459.67 }
                           ^
solution.rb:4:1: C: Tab detected.
	(degrees * coefficient[src_units] + constant[src_units] - constant[target_units]) / coefficient[target_units]
^
solution.rb:8:5: C: Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
    'water'   => {melting_point: 0,     boiling_point: 100  },
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
solution.rb:16:1: C: Use 2 (not 4) spaces for indentation.
    convert_between_temperature_units(SUBSTANCES[substance][:melting_point], 'C', units)
^^^^
solution.rb:20:1: C: Use 2 (not 4) spaces for indentation.
    convert_between_temperature_units(SUBSTANCES[substance][:boiling_point], 'C', units)
^^^^

1 file inspected, 6 offenses detected
F

Failures:

  1) ruby-retrospective-2016 covers the minimum requirements
     Failure/Error: system(command) or raise "Command failed for #{@solutions_repo}: #{command}"
     RuntimeError:
       Command failed for https://github.com/lovechief/ruby-retrospective-2016: bundle exec rake check_all
     # /tmp/d20170211-11010-10p2hud/spec.rb:82:in `execute'
     # /tmp/d20170211-11010-10p2hud/spec.rb:75:in `block (3 levels) in solutions_pass_all_checks'
     # /tmp/d20170211-11010-10p2hud/spec.rb:74:in `chdir'
     # /tmp/d20170211-11010-10p2hud/spec.rb:74:in `block (2 levels) in solutions_pass_all_checks'
     # /tmp/d20170211-11010-10p2hud/spec.rb:40:in `chdir'
     # /tmp/d20170211-11010-10p2hud/spec.rb:40:in `block in solutions_pass_all_checks'
     # /tmp/d20170211-11010-10p2hud/spec.rb:39:in `solutions_pass_all_checks'
     # /tmp/d20170211-11010-10p2hud/spec.rb:19:in `ok?'
     # /tmp/d20170211-11010-10p2hud/spec.rb:101:in `<top (required)>'

Finished in 0.00091 seconds
1 example, 1 failure

Failed examples:

rspec /tmp/d20170211-11010-10p2hud/spec.rb:107 # ruby-retrospective-2016 covers the minimum requirements

История (5 версии и 0 коментара)