Христо обнови решението на 13.11.2016 17:01 (преди над 7 години)
+RSpec.describe 'Version' do
+ it 'accepts proper input' do
+ expect(Version.new('1.2.3')).to eq('1.2.3')
+ end
+
+ it 'doesnt kill unnecessary 0s' do
+ expect(Version.new("1.0.1.0.1.0")).to eq("1.0.1.0.1")
+ end
+
+ it 'doesnt kill unnecessary 0s' do
+ expect(Version.new("1.0.1.0.1")).to eq("1.0.1.0.1")
+ end
+
+ it 'recognises an error' do
+ expect { Version.new('0..3') } .to raise_error(ArgumentError)
+ end
+
+ it 'tells you when you have tried a completely invalid input' do
+ expect { Version.new('1.1.a') } .to raise_error(ArgumentError)
+ end
+
+ it 'tells you when you have tried a completely invalid input' do
+ expect { Version.new('a') } .to raise_error(ArgumentError)
+ end
+
+ it 'tells you when you have tried a completely invalid input' do
+ expect { Version.new('1,1,1') } .to raise_error(ArgumentError)
+ end
+
+ it 'tells you when you have tried a negative number' do
+ expect { Version.new('-1.1.1') } .to raise_error(ArgumentError)
+ end
+
+ it 'tells you when you have tried a negative number' do
+ expect { Version.new('1.1.-0') } .to raise_error(ArgumentError)
+ end
+
+ it 'tells you when you try something funny' do
+ expect(Version.new('1') == Version.new('1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0'))
+ .to eq(true)
+ end
+
+ it 'tells you when you try something funny' do
+ expect(Version.new('1') == Version.new('1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.1'))
+ .to eq(false)
+ end
+
+ # input check ends here
+ it 'knows the example test' do
+ expect(Version.new('1.2.3') < Version.new('1.3.1')).to eq(true)
+ end
+
+ it 'knows >' do
+ expect(Version.new("1.1.1") > Version.new("1.1.0")).to eq(true)
+ end
+
+ it 'knows ==' do
+ expect(Version.new("1.1.0") == Version.new("1.1")).to eq(true)
+ end
+
+ it 'knows <' do
+ expect(Version.new("1.1.0") < Version.new("1.1.1")).to eq(true)
+ end
+
+ it 'knows >=' do
+ expect(Version.new("1.1.1") >= Version.new("1.1.0")).to eq(true)
+ end
+
+ it 'knows >=' do
+ expect(Version.new("1.1.0") >= Version.new("1.1")).to eq(true)
+ end
+
+ it 'knows <=' do
+ expect(Version.new("1.1.0") <= Version.new("1.1.1")).to eq(true)
+ end
+
+ it 'knows <=' do
+ expect(Version.new("1.1") <= Version.new("1.1.0")).to eq(true)
+ end
+
+ # oy vey
+
+ it 'knows false >' do
+ expect(Version.new("1.1.0") > Version.new("1.1.1")).to eq(false)
+ end
+
+ it 'knows false >' do
+ expect(Version.new("1.1") > Version.new("1.1.0")).to eq(false)
+ end
+
+ it 'knows false ==' do
+ expect(Version.new("1.1.0") == Version.new("1.1.1")).to eq(false)
+ end
+
+ it 'knows false <' do
+ expect(Version.new("1.1.1") < Version.new("1.1.0")).to eq(false)
+ end
+
+ it 'knows false <' do
+ expect(Version.new("1.1") < Version.new("1.1.0")).to eq(false)
+ end
+
+ it 'knows false >=' do
+ expect(Version.new("1.1.0") >= Version.new("1.1.1")).to eq(false)
+ end
+
+ it 'knows false <=' do
+ expect(Version.new("1.1.1") <= Version.new("1.1.0")).to eq(false)
+ end
+
+ # oy gevalt
+
+ it 'knows >' do
+ expect(Version.new("1.2.1") > Version.new("1.1.1")).to eq(true)
+ end
+
+ it 'knows ==' do
+ expect(Version.new("1.2.0") == Version.new("1.2")).to eq(true)
+ end
+
+ it 'knows <' do
+ expect(Version.new("1.1.1") < Version.new("1.2.1")).to eq(true)
+ end
+
+ it 'knows >=' do
+ expect(Version.new("1.2.1") >= Version.new("1.1.1")).to eq(true)
+ end
+
+ it 'knows >=' do
+ expect(Version.new("1.2") >= Version.new("1.2.0")).to eq(true)
+ end
+
+ it 'knows <=' do
+ expect(Version.new("1.1.1") <= Version.new("1.2.1")).to eq(true)
+ end
+
+ it 'knows <=' do
+ expect(Version.new("1.2") <= Version.new("1.2.0")).to eq(true)
+ end
+
+ # oy vey
+
+ it 'knows false >' do
+ expect(Version.new("1.1.1") > Version.new("1.2.1")).to eq(false)
+ end
+
+ it 'knows false >' do
+ expect(Version.new("1.2.0") > Version.new("1.2")).to eq(false)
+ end
+
+ it 'knows false ==' do
+ expect(Version.new("1.2.1") == Version.new("1.2.2")).to eq(false)
+ end
+
+ it 'knows false <' do
+ expect(Version.new("1.2.1") < Version.new("1.1.1")).to eq(false)
+ end
+
+ it 'knows false <' do
+ expect(Version.new("1.2.0") < Version.new("1.2")).to eq(false)
+ end
+
+ it 'knows false >=' do
+ expect(Version.new("1.1.1") >= Version.new("1.2.1")).to eq(false)
+ end
+
+ it 'knows false <=' do
+ expect(Version.new("1.2.1") <= Version.new("1.1.1")).to eq(false)
+ end
+
+ # the goyim know
+
+ it 'knows <=>' do
+ expect(Version.new("1.2.1") <=> Version.new("1.1.1")).to eq(1)
+ end
+
+ it 'knows <=>' do
+ expect(Version.new("1.2.0") <=> Version.new("1.2")).to eq(0)
+ end
+
+ it 'knows <=>' do
+ expect(Version.new("1.1.1") <=> Version.new("1.2.1")).to eq(-1)
+ end
+
+ # < > = should be ready
+
+ it 'knows 0.1 != 1' do
+ expect(Version.new("1") != Version.new("0.1")).to eq(true)
+ end
+
+ it 'knows 0/nothing is smaller than anything' do
+ expect(Version.new("") < Version.new("0.1")).to eq(true)
+ end
+
+ it 'knows 1.1.0 == 1.1' do
+ expect(Version.new("1.1.0") == Version.new("1.1")).to eq(true)
+ end
+ # to string
+
+ it 'returns regular array' do
+ expect(Version.new("1.2.3.4").to_s).to eq("1.2.3.4")
+ end
+
+ it 'returns array with a zero at end' do
+ expect(Version.new("1.2.3.0").to_s).to eq("1.2.3")
+ end
+
+ it 'returns an array with a 0 within' do
+ expect(Version.new("1.0.3.1").to_s).to eq("1.0.3.1")
+ end
+
+ it 'returns an array with a 0 in the beginning' do
+ expect(Version.new("0.0.3.1").to_s).to eq("0.0.3.1")
+ end
+
+ # components
+
+ it 'returns a regular array' do
+ expect(Version.new("1.2.3.4").components).to eq([1, 2, 3, 4])
+ end
+
+ it 'returns array with a zero at end' do
+ a = Version.new("1.2.3.0")
+ expect(a.components).to eq([1, 2, 3])
+ end
+
+ it 'returns an array with a 0 within' do
+ a = Version.new("1.0.3.1")
+ expect(a.components).to eq([1, 0, 3, 1])
+ end
+
+ it 'returns proper components(3)' do
+ a = Version.new("1.2.3.4")
+ expect(a.components(3)).to eq([1, 2, 3])
+ expect { a.components(3) } .to_not change { a }
+ end
+
+ it 'knows what to do with a larger N' do
+ a = Version.new("1.2.3")
+ expect(a.components(8)).to eq([1, 2, 3, 0, 0, 0, 0, 0])
+ expect { a.components(8) } .to_not change { a }
+ end
+
+ it 'knows what to do with cheesy stuff' do
+ a = Version.new("1.2.3.0")
+ expect(a.components(4)).to eq([1, 2, 3, 0])
+ expect { a.components(4) } .to_not change { a }
+ end
+
+ it 'knows what to do with cheesy stuff and a larger N' do
+ a = Version.new("1.2.3.0")
+ expect(a.components(8)).to eq([1, 2, 3, 0, 0, 0, 0, 0])
+ expect { a.components(8) } .to_not change { a }
+ end
+
+ describe 'Range' do
+ it 'runs the example' do
+ expect(
+ (Version::Range.new(Version.new('1'), Version.new('2'))
+ .include? Version.new('1.5'))
+ ).to eq(true)
+ end
+
+ it 'knows when there is an error' do
+ expect(
+ (Version::Range.new(Version.new('1'), Version.new('2'))
+ .include? Version.new('20'))
+ ).to eq(false)
+ end
+
+ it 'knows 2 is not within (1;2)' do
+ expect(
+ (Version::Range.new(Version.new('1'), Version.new('2'))
+ .include? Version.new('2'))
+ ).to eq(false)
+ end
+
+ it 'throws ArgumentError' do
+ expect { Version::Range.new('1', '5').include? 'a.2' }
+ .to raise_error(ArgumentError)
+ end
+
+ it 'throws ArgumentError 2' do
+ expect { Version::Range.new('a', '5').include? '1.2' }
+ .to raise_error(ArgumentError)
+ end
+
+ it 'throws ArgumentError 3' do
+ expect { Version::Range.new('1', 'b').include? '1.2' }
+ .to raise_error(ArgumentError)
+ end
+
+ it 'knows string ranges' do
+ expect((Version::Range.new('1', '5').include? '2.2')).to eq(true)
+ end
+
+ it 'knows string ranges 2' do
+ expect(
+ (Version::Range.new('1', '5')
+ .include? Version.new('2.2'))
+ ).to eq(true)
+ end
+
+ it 'knows string ranges 3' do
+ expect(
+ (Version::Range.new(Version.new('1'), Version.new('5'))
+ .include? '2.2')
+ ).to eq(true)
+ end
+
+ # include
+
+ it 'can make example arrays' do
+ expect(
+ Version::Range.new(Version.new('1.1.0'), Version.new('1.2.2'))
+ .to_a
+ ).to eq(
+ [
+ '1.1', '1.1.1', '1.1.2', '1.1.3', '1.1.4', '1.1.5',
+ '1.1.6', '1.1.7', '1.1.8', '1.1.9', '1.2', '1.2.1'
+ ]
+ )
+ end
+
+ it 'can make small arrays' do
+ expect(
+ Version::Range.new(Version.new('1.1.0'), Version.new('1.1.1'))
+ .to_a
+ ).to eq(['1.1.0'])
+ end
+
+ it 'knows what to do with a bad array' do
+ expect(
+ Version::Range.new(Version.new('1.1.1'), Version.new('1.1.1'))
+ .to_a
+ ).to eq([])
+ end
+
+ it 'knows what to do with another bad array' do
+ expect(
+ Version::Range.new(Version.new('2.1.1'), Version.new('1.1.1'))
+ .to_a
+ ).to eq([])
+ end
+ end
+end
Това.......... Нормално ли е? Или съм изпуснал някоя тънкост :|
Кое дали е нормално? :)
т.е. дали съм схванал идеята, или има и начин решението да не е 350 реда
Дължината не трябва да те притеснява. Можеш да обединиш няколко теста, ако проверяват една и съща логика. Например, всичките, които тестват <=, или дори всички, които тестват неравенства. Не е задължително да имаш само един expect в it, стига да не тестват различна логика. Аз бих обединил, например <, >, <= и >= в един или два it-а.
На какво ниво ще ги обединиш зависи от теб - въпрос на избор е.